Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] Disable NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds #96053

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 15, 2023

Backport of #79407 to release/7.0-staging
6.0 PR is #96055

Fixes #91705

/cc @rzikm, @karelz

Customer Impact

Test only change to clean up CI. The test uses external server (badssl.com) which has now expired certificate (see also chromium/badssl.com#515). The test fails because the certificate validation errors differ from the tests expectations.

Testing

Will run CI to check affected test.

Risk

Low, test-only change.

…g_Succeeds

The 3rd party service has expired certificate
@ghost
Copy link

ghost commented Dec 15, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79407 to release/7.0-staging

/cc @rzikm

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@rzikm rzikm changed the title [release/7.0-staging] Temporarily disable NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds [release/7.0-staging] Disable NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds Dec 15, 2023
@rzikm
Copy link
Member

rzikm commented Dec 15, 2023

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm
Copy link
Member

rzikm commented Jan 2, 2024

Test-only change => tell mode, adding Servicing-approved

@rzikm rzikm added the Servicing-approved Approved for servicing release label Jan 2, 2024
@karelz karelz added this to the 7.0.x milestone Jan 4, 2024
@rzikm
Copy link
Member

rzikm commented Jan 4, 2024

CI Failures are unrelated.

@rzikm rzikm merged commit 6d21550 into release/7.0-staging Jan 4, 2024
99 of 123 checks passed
@akoeplinger akoeplinger deleted the backport/pr-79407-to-release/7.0-staging branch January 10, 2024 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
@karelz karelz added the test-bug Problem in test source code (most likely) label Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http Servicing-approved Approved for servicing release test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants