Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source build GitHub team name #4646

Merged
merged 1 commit into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Documentation/eliminating-pre-builts.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ contains package information of pre-builts that for one reason or another are
allowed in the source-build of the repository.

Any new addition to the pre-built exception list must be signed-off by a member
of the `@dotnet/source-build-internal` team.
of the `@dotnet/source-build` team.

A common example of a exception that is present in several .NET repositories is
an [_intermediate
Expand Down
4 changes: 2 additions & 2 deletions Documentation/sourcebuild-in-repos/new-dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ dependency and the nuances it may have.
1. Is the repo already built in source-build but the specific package is not?
1. There's probably an issue with source-building this package. Please talk
to a [source-build team
member](https://github.com/orgs/dotnet/teams/source-build-internal) about
member](https://github.com/orgs/dotnet/teams/source-build) about
why that is and whether we can fix it.
1. Is this a repo that uses Arcade to build?
1. Does the foreign repo depend on your repo, directly or indirectly? i.e.
would adding the dependency create a cycle?
1. This isn't necessarily a deal-breaker - it can sometimes be worked
around with reference-only packages. Please contact a [source-build
team
member](https://github.com/orgs/dotnet/teams/source-build-internal) to
member](https://github.com/orgs/dotnet/teams/source-build) to
discuss.
1. Does the foreign repo publish to BAR?
1. If not, please contact them to get them publishing to BAR in an
Expand Down
8 changes: 4 additions & 4 deletions Documentation/sourcebuild-in-repos/new-repo.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ MSBuild code that can change the way source build behaves.
### `eng/SourceBuildPrebuiltBaseline.xml`

```xml
<!-- Whenever altering this or other Source Build files, please include @dotnet/source-build-internal as a reviewer. -->
<!-- Whenever altering this or other Source Build files, please include @dotnet/source-build as a reviewer. -->
<!-- See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. -->

<UsageData>
Expand All @@ -86,7 +86,7 @@ Add the source build team as the
of the source build infrastructure.

``` text
/eng/SourceBuild* @dotnet/source-build-internal
/eng/SourceBuild* @dotnet/source-build
```

### Trying it out locally
Expand Down Expand Up @@ -247,7 +247,7 @@ To opt in:
#### End result

Submit the changes above in a PR and include
[@source-build-internal](https://github.com/orgs/dotnet/teams/source-build-internal)
[@source-build](https://github.com/orgs/dotnet/teams/source-build)
as a reviewer. The jobs (or job, if managed-only) are automatically be added to
CI in the existing pipeline alongside existing jobs, with a name like `Build
Source-Build (<Platform>)`:
Expand Down Expand Up @@ -355,7 +355,7 @@ flow into `dotnet/installer`, a complete .NET product can be built from source.
The repository will be synchronized into the VMR during the first build and the
VMR will be built. This will validate that no prebuilts were added to the system
and everything is functioning correctly. Please notify
[@source-build-internal](https://github.com/orgs/dotnet/teams/source-build-internal)
[@source-build](https://github.com/orgs/dotnet/teams/source-build)
to be on the lookout for the new repo and they will validate as necessary.

## Additional resources
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ branch (e.g. runtime release/6.0 to sdk release/6.0.1xx, release/6.0.2xx, etc).
Package versions that you are updating to should be source-built in their
respective repos. If the version you need is produced in a branch that is not
yet source-build-compatible please let the [source-build
team](https://github.com/orgs/dotnet/teams/source-build-internal) know.
team](https://github.com/orgs/dotnet/teams/source-build) know.

Another common error we see is updating eng/Versions.props but not
eng/Version.Details.xml. This causes problems for source-build because we
Expand Down