Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudfront CSV #13

Open
Marc-9 opened this issue Apr 15, 2020 · 2 comments
Open

Cloudfront CSV #13

Marc-9 opened this issue Apr 15, 2020 · 2 comments

Comments

@Marc-9
Copy link

Marc-9 commented Apr 15, 2020

Didn't see a way of contacting you so Id thought I do it through here, I found your code why google searching some of the domains I found, and found your util.py
Was particularly looking at
csv_url = f"https://{cdn}.cloudfront.net/short/inc/{player_or_team}s_search_list.csv"

What do you mean by {player_or_team} would I replace this with its unique id?
Ive found some links such as
https://d6rt22vwfyr3i.cloudfront.net/short/inc/players_search_list.csv
and
https://d6rt22vwfyr3i.cloudfront.net/short/inc/clubs_search_list.csv

But if I wanted info on a player doing
https://d6rt22vwfyr3i.cloudfront.net/short/inc/19538871_search_list.csv
Does not load

I was wondering what the significance of the line meant thanks

@Marc-9
Copy link
Author

Marc-9 commented Apr 15, 2020

19538871 being the id for Manchester United

@double-dose-larry
Copy link
Owner

double-dose-larry commented Jun 10, 2020

The way that fbref works slightly differently then the other sports-reference websites. look up the id in the clubs csv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants