Fix possible file corruptions via fmt hook #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustfmt should not be called on multiple files, since it can update included files as well, which will lead to writing different files without a lock, and inevitably will corrupt them.
azat
added a commit
to azat/chdig
that referenced
this pull request
Jul 25, 2024
The problem is that rustfmt called on multiple files, while this will lead to concurrent file modifications, see [1]. [1]: doublify/pre-commit-rust#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustfmt should not be called on multiple files, since it can update included files as well, which will lead to writing different files without a lock, and inevitably will corrupt them.