Auto Homing
#289
Replies: 1 comment
-
@MarkusSchneider More logs for your analyzing pleasure! This is from an ERG ride on Zwift with the newest auto_min_max #284 Build. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@MarkusSchneider , I'd like your input on auto homing in PR #284
When setting the MIN stepper position using powertable, what should happen when the minimum limit is reached?
SmartSpin2k/src/Main.cpp
Lines 222 to 226 in fedebad
So with the current code, it will only limit the stepper from moving further, but I'm not sure that's the best solution. Should it also cap or reset rtConfig.shifterPosition and maybe do something to rtConfig.TargetIncline as well?
Or am I overthinking it and just placing a limit on the actual stepper movement is best? In Sim mode, the user will probably want to shift up (if they're sitting at the bottom limit) anyway which would fix the problem. In ERG mode, it should self correct as we don't allow ERG setpoints below 50w (I will probably set the Min position to ~45w if we have >5 readings at the 50w level.)
After typing this out, I think I am probably overthinking it and simply capping the stepper movement is best, but I'd still love to hear your (any anyone else's) input.
Beta Was this translation helpful? Give feedback.
All reactions