Multi-Species Codes and Tests #273
Conversation
… into inviscid-real-gas-physics
… AllRealGasConstants so they can be accessed as an object
… into inviscid-real-gas-physics
…lly a mono-species N2 air
…iscid_real_gas.cpp now except for file reading)
it passed compile but segmentation fault when running
…ative solutions of initial condition to prevent errors
…es using if statements, mono-species inviscid real gas test has verified)
it works without problems (1D, calorically perfect, 2-species)
(they are moved to multi_species directory)
it means that the multi-species code can compute the test cases under the following conditions; 1D... up to 4-species 2D... up to 3-species 3D... up to 2-species test cases
it is a 2-species test
it is a 2-species test (uniform density and air composition)
it is a 2-species test (uniform mixture density)
|
There was a problem hiding this comment.
this file should be somewhere else
There was a problem hiding this comment.
this file should be somewhere else
| @@ -10,7 +10,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror") | |||
| set(MPIMAX 4 CACHE STRING "Default number of processors used in ctest mpirun -np MPIMAX. Not the same as ctest -jX") | |||
|
|
|||
|
|
|||
| #set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Og -g") | |||
| set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Og -g") | |||
There was a problem hiding this comment.
what was this needed for?
| } else if (pde_type == PDE_enum::real_gas) { | ||
| // TO DO: will need to modify the nstate; i suggest adding it as a compile time constant; eg PHiLiP_2D_10species then nstate=(nspecies-1)+dim+2 | ||
| // TO DO: modify this when you change number of species | ||
| return std::make_shared< DGWeak<dim,dim+2+2-1,real,MeshType> >(parameters_input, degree, max_degree_input, grid_degree_input, triangulation_input); // TO DO: N_SPECIES | ||
| } else if (pde_type == PDE_enum::multi_species_calorically_perfect_euler) { | ||
| // TO DO: will need to modify the nstate; i suggest adding it as a compile time constant; eg PHiLiP_2D_10species then nstate=(nspecies-1)+dim+2 | ||
| // TO DO: modify this when you change number of species | ||
| return std::make_shared< DGWeak<dim,dim+2+2-1,real,MeshType> >(parameters_input, degree, max_degree_input, grid_degree_input, triangulation_input); // TO DO: N_SPECIES |
There was a problem hiding this comment.
same for other changes in this file
There was a problem hiding this comment.
when reviewing your own PR, go over once more so that unnecessary small changes like this are not included; makes the review much easier and avoids merge conflicts later one
| @@ -51,4 +51,4 @@ foreach(dim RANGE 1 3) | |||
| unset(InitialConditionsLib) | |||
| unset(PODLib) | |||
| unset(MeshAdaptationLib) | |||
| endforeach() | |||
| endforeach() | |||
There was a problem hiding this comment.
revert small changes like this
There was a problem hiding this comment.
clean up the comments or address the TO DO; I'm seeing this in other files too
| pcout << "Finished integration test with run error code: " << run_error << std::endl; | ||
| } | ||
| } |
There was a problem hiding this comment.
revert all unnecessary changes like this
Summary
This pull request introduces a multi-species solver for inviscid flows (Euler equations). It supports both calorically imperfect and perfect gas models and can handle up to 4 species in 1D, 3 species in 2D, and 2 species in 3D computations. Tests are included to verify and validate the implementation against various cases.
Features
Multi-Species Solver
Implementation Details
New Files
Tests Added
Some tests failed; these are already reported in GitHub and unrelated to the changes introduced in this PR.
TestLog.txt
Details of the algorithms, physics, equations, and results are summarized in Liki's Master's thesis.