Added webform states js to allow pattern use in drupal states. #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdNadimHossain
requested review from
anthony-malkoun,
vincent-gao and
yeniatencio
MdNadimHossain
commented
Sep 11, 2024
| @@ -55,7 +55,7 @@ Feature: Access permissions | |||
| Given I go to "user/password" | |||
| Then I fill in "Username or email address" with "test@example.com" | |||
| And I press "Submit" | |||
| And I should see the success message "If the username or email address exists and is active, further instructions have been sent to your email address." | |||
| And I should see the success message "If test@example.com is a valid account, an email will be sent with instructions to reset your password." | |||
There was a problem hiding this comment.
this test has been updated related to the recent release and issue fix in username_enumeration_prevention. The issue that has been fixed.
vincent-gao
approved these changes
Sep 12, 2024
| @@ -55,7 +55,7 @@ Feature: Access permissions | |||
| Given I go to "user/password" | |||
| Then I fill in "Username or email address" with "test@example.com" | |||
| And I press "Submit" | |||
| And I should see the success message "If the username or email address exists and is active, further instructions have been sent to your email address." | |||
| And I should see the success message "If test@example.com is a valid account, an email will be sent with instructions to reset your password." | |||
…place-for-all-nodes
MdNadimHossain
deleted the
bug/SD-231-moved-state-pattern-js-global-place-for-all-nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SD-231
Problem/Motivation
Drupal states pattern was not working for promotion and navigation card component for other content types.
Fix
Moved the js that is being used from webform module (which has the pattern addition for drupal states) for all node forms .
Related PRs
dpc-sdp/tide_landing_page#234
Notes
Initially it was targeting only landing page as the component was only added for landing pages. Now the component is being used for publication page and it might get used for other content types in the future. So loading it for all node edit forms from tide_core.
Screenshots
TODO