Skip to content
This repository has been archived by the owner on Sep 29, 2024. It is now read-only.

deleted style field #230

Merged
merged 21 commits into from
Aug 27, 2024

Conversation

yeniatencio
Copy link
Contributor

@yeniatencio yeniatencio commented Jul 29, 2024

Ticket: https://digital-vic.atlassian.net/browse/SD-17
We want to remove style option from call to action component.

Testing link: https://nginx-php.pr-428.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/

Screenshot 2024-08-05 at 3 16 18 pm

Steps:

  1. Removed style option field and update hook to roll out the updates.
  2. Updated the description of the component in the field config/install for new sites and roll out the description update using the update hook for existing site.
  3. Added a separate update hook to update the weight of the component to make it appear next to Ke dates component.

Copy link
Contributor

@vincent-gao vincent-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @yeniatencio
There are a couple of dependency concerns:

  1. all of tide modules they don't have dependency with drush, so I think you don't want to introduce drush dependency here.
  2. https://github.com/dpc-sdp/tide_landing_page/pull/230/files#diff-7e6f6816fd76f77a0b74239e31ba4e5b1e332854d8e55ceae374edfe98dfe08bR98 could potentially overwrite configurations unintentionally for some projects, since the landing_page is used across all sites.

@yeniatencio
Copy link
Contributor Author

hey @yeniatencio There are a couple of dependency concerns:

  1. all of tide modules they don't have dependency with drush, so I think you don't want to introduce drush dependency here.
  2. https://github.com/dpc-sdp/tide_landing_page/pull/230/files#diff-7e6f6816fd76f77a0b74239e31ba4e5b1e332854d8e55ceae374edfe98dfe08bR98 could potentially overwrite configurations unintentionally for some projects, since the landing_page is used across all sites.

Hey @vincent-gao , regarding to your feedback:

  1. I need a dependency with drush. If that's not the correct place to add it then please point me where it should be added instead.
  2. Please be more specific and suggest what is the best approach because the ticket is requesting to remove a field.

Copy link
Contributor

@MdNadimHossain MdNadimHossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please get a 2nd opinion from @vincent-gao

@yeniatencio yeniatencio merged commit ebb399b into develop Aug 27, 2024
5 of 8 checks passed
@yeniatencio yeniatencio deleted the feature/SD-17-remove-style-field-call-to-action branch August 27, 2024 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants