This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
deleted style field #230
Merged
yeniatencio
merged 21 commits into
develop
from
feature/SD-17-remove-style-field-call-to-action
Aug 27, 2024
Merged
deleted style field #230
yeniatencio
merged 21 commits into
develop
from
feature/SD-17-remove-style-field-call-to-action
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeniatencio
requested review from
vincent-gao,
MdNadimHossain and
anthony-malkoun
August 5, 2024 05:44
vincent-gao
suggested changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @yeniatencio
There are a couple of dependency concerns:
- all of tide modules they don't have dependency with drush, so I think you don't want to introduce drush dependency here.
- https://github.com/dpc-sdp/tide_landing_page/pull/230/files#diff-7e6f6816fd76f77a0b74239e31ba4e5b1e332854d8e55ceae374edfe98dfe08bR98 could potentially overwrite configurations unintentionally for some projects, since the landing_page is used across all sites.
Hey @vincent-gao , regarding to your feedback:
|
MdNadimHossain
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but please get a 2nd opinion from @vincent-gao
vincent-gao
approved these changes
Aug 27, 2024
yeniatencio
deleted the
feature/SD-17-remove-style-field-call-to-action
branch
August 27, 2024 07:02
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://digital-vic.atlassian.net/browse/SD-17
We want to remove style option from call to action component.
Testing link: https://nginx-php.pr-428.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/
Steps: