Skip to content

Commit

Permalink
Cleanup formatting, no functional changes
Browse files Browse the repository at this point in the history
Cleanup the formatting, remove parens, extraneous spaces, etc.
  • Loading branch information
jeffwidman committed Nov 20, 2018
1 parent fcc800f commit 7444e07
Showing 1 changed file with 23 additions and 23 deletions.
46 changes: 23 additions & 23 deletions test/test_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,22 @@ def test_config_resource():
with pytest.raises(KeyError):
bad_resource = kafka.admin.ConfigResource('something', 'foo')
good_resource = kafka.admin.ConfigResource('broker', 'bar')
assert(good_resource.resource_type == kafka.admin.ConfigResourceType.BROKER)
assert(good_resource.name == 'bar')
assert(good_resource.configs is None)
good_resource = kafka.admin.ConfigResource(kafka.admin.ConfigResourceType.TOPIC, 'baz', {'frob' : 'nob'})
assert(good_resource.resource_type == kafka.admin.ConfigResourceType.TOPIC)
assert(good_resource.name == 'baz')
assert(good_resource.configs == {'frob' : 'nob'})
assert good_resource.resource_type == kafka.admin.ConfigResourceType.BROKER
assert good_resource.name == 'bar'
assert good_resource.configs is None
good_resource = kafka.admin.ConfigResource(kafka.admin.ConfigResourceType.TOPIC, 'baz', {'frob': 'nob'})
assert good_resource.resource_type == kafka.admin.ConfigResourceType.TOPIC
assert good_resource.name == 'baz'
assert good_resource.configs == {'frob': 'nob'}


def test_new_partitions():
good_partitions = kafka.admin.NewPartitions(6)
assert(good_partitions.total_count == 6)
assert(good_partitions.new_assignments is None)
assert good_partitions.total_count == 6
assert good_partitions.new_assignments is None
good_partitions = kafka.admin.NewPartitions(7, [[1, 2, 3]])
assert(good_partitions.total_count == 7)
assert(good_partitions.new_assignments == [[1, 2, 3]])
assert good_partitions.total_count == 7
assert good_partitions.new_assignments == [[1, 2, 3]]


def test_new_topic():
Expand All @@ -32,16 +32,16 @@ def test_new_topic():
with pytest.raises(IllegalArgumentError):
bad_topic = kafka.admin.NewTopic('foo', 1, -1)
with pytest.raises(IllegalArgumentError):
bad_topic = kafka.admin.NewTopic('foo', 1, 1, {1 : [1, 1, 1]})
bad_topic = kafka.admin.NewTopic('foo', 1, 1, {1: [1, 1, 1]})
good_topic = kafka.admin.NewTopic('foo', 1, 2)
assert(good_topic.name == 'foo')
assert(good_topic.num_partitions == 1)
assert(good_topic.replication_factor == 2)
assert(good_topic.replica_assignments == {})
assert(good_topic.topic_configs == {})
good_topic = kafka.admin.NewTopic('bar', -1, -1, {1 : [1, 2, 3]}, {'key' : 'value'})
assert(good_topic.name == 'bar')
assert(good_topic.num_partitions == -1)
assert(good_topic.replication_factor == -1)
assert(good_topic.replica_assignments == {1: [1, 2, 3]})
assert(good_topic.topic_configs == {'key' : 'value'})
assert good_topic.name == 'foo'
assert good_topic.num_partitions == 1
assert good_topic.replication_factor == 2
assert good_topic.replica_assignments == {}
assert good_topic.topic_configs == {}
good_topic = kafka.admin.NewTopic('bar', -1, -1, {1: [1, 2, 3]}, {'key': 'value'})
assert good_topic.name == 'bar'
assert good_topic.num_partitions == -1
assert good_topic.replication_factor == -1
assert good_topic.replica_assignments == {1: [1, 2, 3]}
assert good_topic.topic_configs == {'key': 'value'}

0 comments on commit 7444e07

Please sign in to comment.