make unbound ctor protected

dpvreony · Jun 16, 2024 · 9e72cd9 · 9e72cd9
1 parent 7e2b9b4
commit 9e72cd9
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/...ourceGenerator/Features/ControlBindingModels/AbstractControlBindingModelClassGenerator.cs b/...ourceGenerator/Features/ControlBindingModels/AbstractControlBindingModelClassGenerator.cs
@@ -274,9 +274,11 @@ private static IEnumerable<TypeParameterSyntax> GetTypeParameterSeparatedSyntaxL
             }
         }
 
-        private MemberDeclarationSyntax GetConstructorMethod(INamedTypeSymbol namedTypeSymbol,
+        private MemberDeclarationSyntax GetConstructorMethod(
+            INamedTypeSymbol namedTypeSymbol,
             bool isDerivedType,
-            bool makeClassesPublic, TypeParameterListSyntax typeParameterList)
+            bool makeClassesPublic,
+            TypeParameterListSyntax typeParameterList)
         {
             var className = GetClassNameIdentifier(namedTypeSymbol);
             var body = GetConstructorBody(isDerivedType);
@@ -306,16 +308,20 @@ private MemberDeclarationSyntax GetConstructorMethod(INamedTypeSymbol namedTypeS
                 ("viewExpression", "expression representing the control on the view to bind to.")
             };
 
+            var modifiers = GetConstructorModifiers(makeClassesPublic);
+
             var declaration = SyntaxFactory.ConstructorDeclaration(className)
                 .WithInitializer(initializer)
                 .WithParameterList(parameters)
-                .AddModifiers(SyntaxFactory.Token(makeClassesPublic ? SyntaxKind.PublicKeyword : SyntaxKind.InternalKeyword))
+                .AddModifiers(modifiers)
                 .AddBodyStatements(body.ToArray())
                 .WithLeadingTrivia(XmlSyntaxFactory.GenerateSummaryComment(summaryText, summaryParameters));
 
             return declaration;
         }
 
+        protected abstract SyntaxToken[] GetConstructorModifiers(bool makeClassesPublic);
+
         private TypeParameterListSyntax GetTypeParameterListSyntax(INamedTypeSymbol namedTypeSymbol)
         {
             var sep = GetTypeParameterSyntaxes();

diff --git a/...eGenerator/Features/ControlBindingModels/ControlBoundControlBindingModelClassGenerator.cs b/...eGenerator/Features/ControlBindingModels/ControlBoundControlBindingModelClassGenerator.cs
@@ -81,6 +81,10 @@ protected override SeparatedSyntaxList<TypeParameterSyntax> GetTypeParameterSynt
             return sep;
         }
 
+        /// <inheritdoc />
+        protected override SyntaxToken[] GetConstructorModifiers(bool makeClassesPublic) =>
+            [SyntaxFactory.Token(makeClassesPublic ? SyntaxKind.PublicKeyword : SyntaxKind.InternalKeyword)];
+
         /// <inheritdoc />
         protected override ClassDeclarationSyntax ApplyBaseClassDeclarationSyntax(
             INamedTypeSymbol namedTypeSymbol,

diff --git a/...SourceGenerator/Features/ControlBindingModels/GenericControlBindingModelClassGenerator.cs b/...SourceGenerator/Features/ControlBindingModels/GenericControlBindingModelClassGenerator.cs
@@ -106,6 +106,10 @@ protected override SeparatedSyntaxList<TypeParameterSyntax> GetTypeParameterSynt
             return sep;
         }
 
+        /// <inheritdoc />
+        protected override SyntaxToken[] GetConstructorModifiers(bool _) =>
+            [SyntaxFactory.Token(SyntaxKind.ProtectedKeyword)];
+
         /// <inheritdoc />
         protected override ClassDeclarationSyntax ApplyBaseClassDeclarationSyntax(
             INamedTypeSymbol namedTypeSymbol,