Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu: Blanks framebuffer before exiting/launching XBEs. #120

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

abaire
Copy link
Contributor

@abaire abaire commented Sep 25, 2021

@abaire abaire force-pushed the blanks_framebuffer_before_reboot branch from 9ca15cc to 4b06ee3 Compare September 25, 2021 15:32
@abaire abaire force-pushed the blanks_framebuffer_before_reboot branch from 4b06ee3 to c09d065 Compare September 26, 2021 00:03
@GXTX
Copy link

GXTX commented Sep 26, 2021

I wonder if it would be better to have this fixed upstream. I know there's discussion already going on as to why artifacts happen.

@abaire
Copy link
Contributor Author

abaire commented Sep 26, 2021

Yup, it's in XboxDev/nxdk/#511 which is where the suggestion to turn off the video output altogether for now came from. The correct fix in the nxdk to allow saving the framebuffer sounds like it'll be be a much larger project.

In my experience memsetting the framebuffer leads to ok results (there's still clearly some corruption but it's not as bad as before the 511 patch) so we could probably do that for now if killing the video ends up having undesired effects.

@dracc dracc merged commit 33ecacf into dracc:master Sep 26, 2021
@abaire abaire deleted the blanks_framebuffer_before_reboot branch September 26, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants