Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qa redirect #1181

Merged
merged 9 commits into from
Jan 26, 2024
Merged

Fix qa redirect #1181

merged 9 commits into from
Jan 26, 2024

Conversation

aapomm
Copy link
Contributor

@aapomm aapomm commented Sep 15, 2023

Spec

Currently, we're saving the session[:return_to] when the user visits the issue/content blocks page. This has unintended results since the session persists through different tabs.

Proposed solution
Pass a param from the QA form to indicate it coming from the QA view. If the param is received, redirect back to the QA #show if the record is still ready for review or #index if not.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to Dradis!

Copyright assignment

Collaboration is difficult with commercial closed source but we want
to keep as much of the OSS ethos as possible available to users
who want to fix it themselves.

In order to unambiguously own and sell Dradis Framework commercial
products, we must have the copyright associated with the entire
codebase. Any code you create which is merged must be owned by us.
That's not us trying to be a jerks, that's just the way it works.

Please review the CONTRIBUTING.md
file for the details.

You can delete this section, but the following sentence needs to
remain in the PR's description:

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

Check List

  • Added a CHANGELOG entry

@aapomm aapomm merged commit 5c02515 into develop Jan 26, 2024
2 of 3 checks passed
@aapomm aapomm deleted the fix-qa-redirect branch January 26, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants