Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_client_pause_with_replica fails #3675

Closed
kostasrim opened this issue Sep 9, 2024 · 0 comments · Fixed by #3729
Closed

test_client_pause_with_replica fails #3675

kostasrim opened this issue Sep 9, 2024 · 0 comments · Fixed by #3729
Assignees
@chakaz
Labels
bug Something isn't working failing-test

Comments

@kostasrim
Copy link
Contributor 

        for cmd, cmd_stats in stats_after_sleep.items():
            if "cmdstat_info" != cmd and "cmdstat_replconf" != cmd_stats:
>               assert stats[cmd] == cmd_stats, cmd
E               AssertionError: cmdstat_multi
E               assert equals failed
E                 {                                {                               
E                   'calls': 78,                     'calls': 79,                  
E                   'usec': 0,                       'usec': 0,                    
E                   'usec_per_call': 0,              'usec_per_call': 0,           
E                 }

https://github.com/dragonflydb/dragonfly/actions/runs/10752326291/job/29820523129#step:6:700
@kostasrim kostasrim added bug Something isn't working failing-test labels Sep 9, 2024
chakaz added a commit that referenced this issue Sep 18, 2024
@chakaz
fix: Fix test test_client_pause_with_replica
80551d0 
There are 2 minor issues with this test:
1. It specified `cmdstat_replconf` as `cmd_stats` instead of `cmd`,
   that's clearly a typo as `cmd_stats` is a map with stats, while
   `replconf` is a Dragonfly command
2. Command `MULTI` is allowed to run even when the server is in paused
   state, see
   [here](https://github.com/dragonflydb/dragonfly/blob/main/src/server/main_service.cc#L1197):

   ```
   // Don't interrupt running multi commands or admin connections.
   ```

Fixes #3675
@chakaz chakaz mentioned this issue Sep 18, 2024
Merged
@chakaz chakaz closed this as completed in a115bc2 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakaz chakaz

Labels
bug Something isn't working failing-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix test test_client_pause_with_replica dragonflydb/dragonfly
2 participants
@chakaz @kostasrim