Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add hostNetwork, topologySpreadConstraint and clusterIP su… #3389

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

katapultcloud
Copy link

We need to run dragonfly on host network each pod on different node with a headless service. This PR will add support for those features.

…pport

Signed-off-by: Stefan Roman <elegant.frog3113@fastmail.com>
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment, It looks good!

Stefan Roman added 2 commits August 2, 2024 17:18
… are not explicitly used

Signed-off-by: Stefan Roman <elegant.frog3113@fastmail.com>
Signed-off-by: Stefan Roman <elegant.frog3113@fastmail.com>
@Pothulapati
Copy link
Contributor

@katapultcloud Sorry for the late reply but the golden tests are failing which means the output has changed. Either update the output files by running go test -v ./... -update and commit htem, or fix the helm charts to generate the current output files.

@katapultcloud
Copy link
Author

@katapultcloud Sorry for the late reply but the golden tests are failing which means the output has changed. Either update the output files by running go test -v ./... -update and commit htem, or fix the helm charts to generate the current output files.

Hey I tried to run the tests locally but I'm getting a pass, I'll try to update the branch but other than that I'm not sure what to do here.

TestHelmRender 2024-08-14T16:42:09+02:00 logger.go:66:           resources:
TestHelmRender 2024-08-14T16:42:09+02:00 logger.go:66:             limits: {}
TestHelmRender 2024-08-14T16:42:09+02:00 logger.go:66:             requests: {}
--- PASS: TestHelmRender (5.04s)
PASS
ok      dragonfly       5.511s

@romange romange enabled auto-merge (squash) September 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants