Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement StatPersistentCachePeerRequest and StatPersistentCacheTaskRequest for persistent cache #3603

Merged
merged 1 commit into from
Oct 23, 2024

feat: implement StatPersistentCachePeerRequest and StatPersistentCach…

7740d94
Select commit
Loading
Failed to load commit list.
Merged

feat: implement StatPersistentCachePeerRequest and StatPersistentCacheTaskRequest for persistent cache #3603

feat: implement StatPersistentCachePeerRequest and StatPersistentCach…
7740d94
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 22, 2024 in 1s

35.47% (target 35.00%)

View this Pull Request on Codecov

35.47% (target 35.00%)

Details

Codecov Report

Attention: Patch coverage is 33.50785% with 127 lines in your changes missing coverage. Please review.

Project coverage is 35.47%. Comparing base (eb4e101) to head (7740d94).

Files with missing lines Patch % Lines
scheduler/service/service_v2.go 32.76% 116 Missing and 3 partials ⚠️
scheduler/resource/persistentcache/peer_manager.go 0.00% 7 Missing ⚠️
scheduler/scheduler.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3603      +/-   ##
==========================================
- Coverage   35.57%   35.47%   -0.10%     
==========================================
  Files         339      339              
  Lines       37190    37308     +118     
==========================================
+ Hits        13231    13236       +5     
- Misses      23120    23233     +113     
  Partials      839      839              
Files with missing lines Coverage Δ
scheduler/resource/persistentcache/host.go 0.00% <ø> (ø)
scheduler/resource/persistentcache/peer.go 0.00% <ø> (ø)
scheduler/rpcserver/rpcserver.go 100.00% <100.00%> (ø)
scheduler/rpcserver/scheduler_server_v2.go 1.26% <100.00%> (ø)
scheduler/service/service_v1.go 79.10% <100.00%> (ø)
scheduler/scheduler.go 0.00% <0.00%> (ø)
scheduler/resource/persistentcache/peer_manager.go 0.00% <0.00%> (ø)
scheduler/service/service_v2.go 65.58% <32.76%> (-6.58%) ⬇️

... and 1 file with indirect coverage changes