Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto detect storage volumeMount while setting it in volumeMounts #205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

weixiao-huang
Copy link

Description

Now we could only use PVC or emptyDir storage for seek-peer in this helm chart. I add a detection in extraVolumeMounts if user sets storage in volumeMounts when there's no persistent storage

Related Issue

Motivation and Context

@gaius-qi
Copy link
Member

@weixiao-huang Please fix lint.

@weixiao-huang weixiao-huang force-pushed the feat/auto-check-storage-mount branch 4 times, most recently from 5da41b1 to 29c7008 Compare December 9, 2023 02:35
@weixiao-huang
Copy link
Author

weixiao-huang commented Feb 23, 2024

I've successfully fixed lint, is there any progress?

Signed-off-by: weixiao-huang <hwx.simle@gmail.com>
Signed-off-by: weixiao-huang <hwx.simle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants