-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] 8333334: C2: Make result of Node::dominates more precise to enhance scalar replacement #105
Conversation
… to enhance scalar replacement Summary: This patch changes the algorithm of `Node::dominates` to make the result more precise, allows the iterators of `ConcurrentHashMap` to be scalar replaced, and makes the iteration ~30% faster. Testing: CI testing, IR test Reviewers: kuaiwei, JoshuaZhuwj Issue: dragonwell-project#104
This backport is not clean due to missing backport of JDK-8287061 (openjdk/jdk#12897), which is too complex to backport. Before applying this backport:
After:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有个建议:因为是patch backport到dw21,所以我们需要考虑将来“后续patch backport”,以及“自动和jdk21同步”是否会产生冲突,所以理想情况是,尽量减少将来backport & auto merge可能产生冲突的可能性。所以可以考虑删除引入“DomResult”,只引入"将Load node加入igvn的worklist“这一个单独的change。但是因为相关的函数本身在后续可能产生冲突的可能性很小,所以这个backport,没有问题。approve. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用all_controls_dominate和maybe_all_controls_dominate的场合有规则吗
其余所有情况都使用 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review! |
[Backport] 8333334: C2: Make result of
Node::dominates
more precise to enhance scalar replacementSummary: This patch changes the algorithm of
Node::dominates
to make the result more precise, allows the iterators ofConcurrentHashMap
to be scalar replaced, and makes the iteration ~30% faster.Testing: CI testing, IR test
Reviewers: kuaiwei, JoshuaZhuwj
Issue: #104