Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JIT] Backport changes to reduce nmethod size in code cache #121

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

kuaiwei
Copy link
Collaborator

@kuaiwei kuaiwei commented Oct 30, 2024

Summary: Include these changes
partial backport of 8329332: Remove CompiledMethod and CodeBlobLayout classes
[Backport] 8329433: Reduce nmethod header size
[Backport] 8331087: Move immutable nmethod data from CodeCache
[Backport] 8331253: 16 bits is not enough for nmethod::_skipped_instructions_size field
[Backport] 8333226: Regressions 2-3% in Compress ZGC after 8331253

Testing: CI testing

Reviewers: Yude Lin, zhuoren.wz

Issue: #88

@kuaiwei kuaiwei force-pushed the reduce_nmethod_review2 branch from 932b142 to ffdd942 Compare October 30, 2024 08:24
@kuaiwei kuaiwei requested review from linade and sandlerwang October 30, 2024 08:33
@kuaiwei kuaiwei force-pushed the reduce_nmethod_review2 branch from 626f91c to 9f84e04 Compare October 30, 2024 10:03
Summary: Include these changes
partial backport of 8329332: Remove CompiledMethod and CodeBlobLayout classes
[Backport] 8329433: Reduce nmethod header size
[Backport] 8331087: Move immutable nmethod data from CodeCache
[Backport] 8331253: 16 bits is not enough for nmethod::_skipped_instructions_size field
[Backport] 8333226: Regressions 2-3% in Compress ZGC after 8331253

Testing: CI testing

Reviewers: Yude Lin, zhuoren.wz

Issue: dragonwell-project#88
@kuaiwei kuaiwei force-pushed the reduce_nmethod_review2 branch from 9f84e04 to e29ea08 Compare October 30, 2024 11:00
Copy link
Collaborator

@linade linade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly identical to the last pr, except for two additional backport 8331253 and 8333226. But 8331253 8333226 almost undo each other, leaving only a few modification to _skipped_instructions_size.

Copy link
Collaborator

@sandlerwang sandlerwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuaiwei kuaiwei merged commit edbda7e into dragonwell-project:master Nov 5, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants