[Backport]String concatenation & StringBuilder appendNull/appendBoolean #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…/String/concat/WithSecurityManager.java test
kuaiwei
reviewed
Jan 3, 2025
| putChar(val, index + 3, c4); | ||
| } | ||
|
|
||
| public static void putCharsAt(byte[] val, int index, int c1, int c2, int c3, int c4, int c5) { |
There was a problem hiding this comment.
为什么这里没有assert index >=0 && index + 4 < length(val)
|
可以说明一下主要冲突的地方吗? |
什么冲突啊？ |
backport到21有冲突吗? 还是clean port |
linade
reviewed
Jan 6, 2025
src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java
Outdated
Show resolved
Hide resolved
不能直接cherry-pick，因为这里依赖的Class File API有很多变化，要把Class File API也port回来就变化太大了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport 我提交给OpenJDK关于字符串拼接的优化，由于有代码共用，所以也backport了优化StringBuilder.append(boolean/null)的优化 PR 19626。
openjdk/jdk#19626 8333893: Optimization for StringBuilder append boolean & null
openjdk/jdk#20253 8336831: Optimize StringConcatHelper.simpleConcat
openjdk/jdk#20273 8336856: Efficient hidden class-based string concatenation strategy
openjdk/jdk#20675 8338930: StringConcatFactory hardCoded string concatenation strategy