Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] 8315046: [Lilliput/JDK21] Cherry-pick: 8305896: Alternative full GC forwarding #70

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

linade
Copy link
Collaborator

@linade linade commented Jun 25, 2024

Backport
8315046: [Lilliput/JDK21] Cherry-pick: 8305896: Alternative full GC forwarding
from lilliput21 repo

Mostly identical to upstream https://bugs.openjdk.org/browse/JDK-8315046 before commit "5b53631dedb Remove flag and template madness".

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@linade linade requested review from weixlu and mmyxym June 25, 2024 08:35
// end of GC_FLAGS
constraint(GCCardSizeInBytesConstraintFunc,AtParse) \
\
develop(bool, UseAltGCForwarding, false, \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop is constant value so we cannot verify this single commit. Shall we use a diagnostic/experimental?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

full GC forwarding

Summary: Backport
8315046: [Lilliput/JDK21] Cherry-pick: 8305896: Alternative full GC
forwarding

Testing: CICD

Reviewers: mmyxym, weixlu

Issue: dragonwell-project#69
Copy link
Collaborator

@weixlu weixlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linade linade merged commit 09618ac into dragonwell-project:master Jul 1, 2024
90 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants