refactor(docker): rm duplicate docker-compose.yml #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
remove-duplicate-docker-compose-files
branch
from
8122dd3
to
675f544
Compare
roschaefer
changed the title
mahula
added
docu
This was referenced Jun 22, 2024
mahula
reviewed
Jun 25, 2024
roschaefer
force-pushed
the
remove-duplicate-docker-compose-files
branch
from
675f544
to
ed59b12
Compare
roschaefer
force-pushed
the
remove-duplicate-docker-compose-files
branch
2 times, most recently
from
5fb3e9e
to
4067eb5
Compare
roschaefer
force-pushed
the
remove-duplicate-docker-compose-files
branch
from
a8419fe
to
0f677c1
Compare
Motivation ---------- I strongly suggest to have one `docker-compose.yml` and one `docker-compose.override.yml` in a central directory, e.g. the root directory. I don't see any good reason to scatter the files across sub-directories. If you want to group services, use [profiles](https://docs.docker.com/compose/profiles/). As a follow up, the different `README`s in each sub-directory needs to be updated. If this PR gets merged, I'm willing to do this. How to test ----------- 1. Nothing to test.
roschaefer
force-pushed
the
remove-duplicate-docker-compose-files
branch
from
70cbfd5
to
301d3d3
Compare
mahula
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I strongly suggest to have one
docker-compose.ymland onedocker-compose.override.ymlin a central directory, e.g. the root directory.I don't see any good reason to scatter the files across sub-directories. If you want to group services, use profiles.
As a follow up, the different
READMEs in each sub-directory needs to be updated. If this PR gets merged, I'm willing to do this.How to test
Todo