Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker): remove placeholder image names #1077

Merged

Conversation

roschaefer
Copy link
Contributor

Motivation

The image in a docker-compose.yml is not required. If you want to build the docker image from the Dockerfile you can simply add a build context.

How to test

  1. docker image rm all the dreammall images
  2. docker compose up
  3. All images get rebuilt

@roschaefer roschaefer changed the title refactor: remove placeholder image names refactor(docker): remove placeholder image names Jun 10, 2024
@Tirokk
Copy link
Member

Tirokk commented Jun 12, 2024

There was a reason why I added code like this to the docker-compose files of ocelot.social and I guess this was a template here.
Before removing this please lets talk.
May I haven't understood something at that time.

Unfortunately I cannot remember my reason at the moment.

@mahula
Copy link
Contributor

mahula commented Jun 22, 2024

There was a reason why I added code like this to the docker-compose files of ocelot.social and I guess this was a template here.

Right, this has just been copied to this project.

Unfortunately I cannot remember my reason at the moment.

Original reason in earlier projects was the busFaktor e.V. running a DockerHub instance as a registered OSS organisation representing all Ocelot.social related docker images.
This does not apply to this project.
This might make the comment in the file obsolete, but we should keep the image parameter to control the image naming for all the contexts they are configured for in the different docker yaml files.
Further ideas regarding the control of docker-related things might be disscussed further in issues related to #1076.

Motivation
----------
The `image` in a `docker-compose.yml` is not required.
If you want to build the docker image from the `Dockerfile` you can simply add a build context.

How to test
-----------
1. `docker image rm` all the dreammall images
2. `docker compose up`
3. All images get rebuilt
@roschaefer roschaefer force-pushed the remove-obsolete-image-names branch from 1824691 to a71d80b Compare July 1, 2024 19:21
@roschaefer roschaefer enabled auto-merge (squash) July 1, 2024 19:22
@roschaefer roschaefer merged commit cdd9e15 into dreammall-earth:master Jul 1, 2024
59 checks passed
@roschaefer roschaefer deleted the remove-obsolete-image-names branch July 1, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants