feat(other): e2e test enter room #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahula
added
feature
1 task
Elweyn
previously approved these changes
Jun 21, 2024
roschaefer
requested changes
Jun 21, 2024
There was a problem hiding this comment.
What's the policy about blocking PR reviews with this team?
For me, I would click on request changes because of the cucumber test. It needs more specification by example, so I would like to see it improved before it gets merged. It goes without saying that I volunteer to help on it.
roschaefer
added a commit
that referenced
this pull request
Jun 21, 2024
Motivation ---------- See this review: #1180 (comment) I want to challenge why we have a `sleep` in our workflow after all. I don't think it's necessary. I will let this run a couple of times and see where it breaks. How to test ----------- 1. Restart the e2e workflow a number of times 2. See if it fails
roschaefer
added a commit
that referenced
this pull request
Jun 21, 2024
Motivation ---------- See this review: #1180 (comment) I want to challenge why we have a `sleep` in our workflow after all. I don't think it's necessary. I will let this run a couple of times and see where it breaks. How to test ----------- 1. Restart the e2e workflow a number of times 2. See if it fails
roschaefer
requested changes
Jun 26, 2024
roschaefer
previously approved these changes
Jun 26, 2024
roschaefer
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Th adds the feature
Tablesand the first tables-related scenario to the end-to-end test suite.Issues