Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): no default layout on auth page #1311

Merged
merged 5 commits into from
Jul 2, 2024
Merged

feat(frontend): no default layout on auth page #1311

merged 5 commits into from
Jul 2, 2024

Conversation

Mogge
Copy link
Contributor

@Mogge Mogge commented Jul 1, 2024 •
edited
Loading

🍰 Pullrequest

To avoid user getting confused, remove default layout on auth and silent refresh page.

Issues

  • None

Todo

  • None

@Mogge Mogge self-assigned this Jul 1, 2024
@Mogge Mogge added feature New feature or request service:frontend labels Jul 1, 2024
Elweyn
Elweyn requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this also on frontend/src/pages/joinRoom/+Page.vue

@Mogge Mogge requested a review from Elweyn July 2, 2024 11:56
@Mogge Mogge merged commit 19dffd2 into master Jul 2, 2024
74 checks passed
@mahula mahula deleted the no-defualt-layout-on-auth-pages branch July 25, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elweyn Elweyn Elweyn approved these changes

Assignees

@Mogge Mogge

Labels
feature New feature or request service:frontend
Projects
Dreammall.earth
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mogge @Elweyn