Skip to content

Commit

Permalink
Improvements added to currency converter
Browse files Browse the repository at this point in the history
  • Loading branch information
elliottminns committed Aug 4, 2024
1 parent 675b1b9 commit 4f2650a
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions 05-currency-converter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,20 @@ rateTo := data.Rates[currencyTo]

converted := amount * (rateTo / rateFrom)
```

### Supported Currencies

For the initial implementation, it may make sense to support a few currencies at first.

In my case, I supported only

- USD
- EUR
- GBP
- JPY

## Improvements

### More currency support

The API you're using should provide a list of currencies they support. One improvement would be to use this list in order to define the supported currencies of your app. You'll want to consider how to make this a good UX however.

0 comments on commit 4f2650a

Please sign in to comment.