Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danctnix: osmin: new pkgbuild #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emulti
Copy link

@emulti emulti commented Jan 20, 2023

PKGBUILD for Osmin (GPS Navigator On-Road/Off-Road for Android and Linux devices)
Upstream URL https://github.com/janbar/osmin
Uses offline maps derived from OpenStreetMap
Tested on Pinephone 1.2. Moderate resource and dependency requirements.
Uses Geoclue Agent for position determination.

@Danct12
Copy link
Member

Danct12 commented Jan 21, 2023

Please change commit name to pkg: danctnix: osmin: new pkgbuild. Thanks.

@emulti emulti changed the title Osmin GPS Maps PKGBUILD adapted from Manajaro danctnix: osmin: new pkgbuild Jan 21, 2023
@Danct12
Copy link
Member

Danct12 commented Jan 23, 2023

That is not what I meant by commit name. You're changing the pull request name, not the commit name.

@emulti
Copy link
Author

emulti commented Jan 24, 2023

Sorry for delay, was without internet for a day
Commit message now changed, do I need to make a new PR or does it migrate to the existing one?

@DrRac27
Copy link
Contributor

DrRac27 commented Jan 24, 2023

You didn't change the commit message, you added another commit. You have to create new commits and force-push them to your branch.
First you have to use git reset HEAD~2 to checkout the commit 2 commits before HEAD (where you are now). With git reset your changes are like never committed. So now you just git add and git commit with the right commit message like you did before. In git log and git show you can check if you did it right. Then you use git push --force to upload your new changes and delete the old commits from github.

@emulti
Copy link
Author

emulti commented Jan 24, 2023

@DrRac27 thank you for the guide. Hopefully it is now correct.

@Danct12
Copy link
Member

Danct12 commented Jan 25, 2023

LGTM (untested)

@Danct12 Danct12 added the enhancement New feature or request label Jan 25, 2023
@mikeshenson
Copy link

I tested this and it worked for me.
Device: PinePhone
OS: Arch Linux Arm with Phosh
Kernel: Linux danctnix 6.1.9-1-danctnix

@AgentSmith0
Copy link

When is this getting merged?

@AgentSmith0
Copy link

@Danct12 Why not merging this? osmin works really well with GPS on the PinePhone (Pro)...

@mikeshenson
Copy link

The version is obsolete.
Also, there is now a PKGBUILD in the AUR[1]

[1] https://aur.archlinux.org/packages/osmin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants