Skip to content

Commit

Permalink
Merge pull request #1011 from jiajic/suite_dev
Browse files Browse the repository at this point in the history
Suite devfix: allow instructions passing for Xenium conv.
  • Loading branch information
jiajic authored Aug 13, 2024
2 parents a1cc4fb + e7c043e commit 9aa3293
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 8 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: Giotto
Title: Spatial Single-Cell Transcriptomics Toolbox
Version: 4.1.0
Version: 4.1.1
Authors@R: c(
person("Ruben", "Dries", email = "rubendries@gmail.com",
role = c("aut", "cre"), comment = c(ORCID = "0000-0001-7650-7754")),
Expand Down
7 changes: 7 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@

# Giotto 4.1.1

## Bug fixes
* Allow `giottoInstructions` passing for Xenium convenience functions


# Giotto 4.1.0 (2024/07/31)

## Breaking changes
Expand Down
2 changes: 1 addition & 1 deletion R/convenience_visiumHD.R
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ setMethod("print", signature("VisiumHDReader"), function(x, ...) show(x))
#' array_subset_col = c(500, 1000))
#'
#' # Create a `giotto` object and add the loaded data
#' TODO
#' # TODO
#' }
#' @export
importVisiumHD <- function(
Expand Down
9 changes: 7 additions & 2 deletions R/convenience_xenium.R
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ setMethod(
load_aligned_images = NULL,
load_expression = FALSE,
load_cellmeta = FALSE,
instructions = NULL,
verbose = NULL
) {
load_expression <- as.logical(load_expression)
Expand Down Expand Up @@ -413,7 +414,7 @@ setMethod(
funs <- obj@calls

# init gobject
g <- giotto()
g <- giotto(instructions = instructions)


# transcripts
Expand Down Expand Up @@ -1215,8 +1216,10 @@ importXenium <- function(
#' slower in our imaging pipeline.
#' @param load_expression logical. Default = FALSE. Whether to load in 10X
#' provided expression matrix.
#' @param load_cellmeta logical. Default = FALSE. Whether to laod in 10X
#' @param load_cellmeta logical. Default = FALSE. Whether to load in 10X
#' provided cell metadata information
#' @param instructions list of instructions or output result from
#' [createGiottoInstructions()]
#' @param verbose logical or NULL. NULL uses the `giotto.verbose` option
#' setting and defaults to TRUE.
#' @returns `giotto` object
Expand Down Expand Up @@ -1282,6 +1285,7 @@ createGiottoXeniumObject <- function(
load_aligned_images = NULL,
load_expression = FALSE,
load_cellmeta = FALSE,
instructions = NULL,
verbose = NULL
) {
x <- importXenium(xenium_dir)
Expand All @@ -1296,6 +1300,7 @@ createGiottoXeniumObject <- function(
load_aligned_images = load_aligned_images,
load_expression = load_expression,
load_cellmeta = load_cellmeta,
instructions = instructions,
verbose = verbose)

# only passed if not null
Expand Down
2 changes: 1 addition & 1 deletion R/feature_set_enrichment.R
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
#' for more details, see:
#' https://software.broadinstitute.org/cancer/software/gsea/wiki/index.php/Data_formats#RNK:_Ranked_list_file_format_.28.2A.rnk.29
#'
#' For more information on parameter convetions,
#' For more information on parameter conventions,
#' please reference GSEA's documentation here:
#' https://www.gsea-msigdb.org/gsea/doc/GSEAUserGuideTEXT.htm#_Syntax
#' @export
Expand Down
6 changes: 5 additions & 1 deletion man/createGiottoXeniumObject.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/doFeatureSetEnrichment.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/importVisiumHD.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9aa3293

Please sign in to comment.