Merge pull request #178 from drieslab/dev

v0.2.2 : hotfix for `createGiottoPolygon()`
drieslab · Mar 1, 2024 · 1812421 · 1812421
2 parents 006d076 + 57cfcb9
commit 1812421
Show file tree

Hide file tree

Showing 17 changed files with 529 additions and 132 deletions.
diff --git a/.github/workflows/covr.yml b/.github/workflows/covr.yml
@@ -27,22 +27,27 @@ jobs:
         with:
           use-public-rspm: true
 
-      - name: Set up dependencies (GiottoData)
-        run: |
-          suppressWarnings({
-            install.packages("remotes")
-            remotes::install_github("drieslab/GiottoData", build = FALSE)
-          })
-        shell: Rscript {0}
-
       - name: Set up dependencies (general)
         uses: r-lib/actions/setup-r-dependencies@v2
         env:
           _R_CHECK_FORCE_SUGGESTS: false
           _R_CHECK_RD_XREFS: false
         with:
           dependencies: '"hard"' # do not use suggested dependencies
-          extra-packages: any::rcmdcheck, any::testthat, any::rlang, any::R.utils, any::sp, any::stars, any::raster, any::sf, any::RTriangle, any::geometry, any::covr
+          install-pandoc: false
+          extra-packages: |
+            github::drieslab/GiottoData
+            any::rcmdcheck
+            any::testthat
+            any::rlang
+            any::R.utils
+            any::sp
+            any::stars
+            any::raster
+            any::sf
+            any::RTriangle
+            any::geometry
+            any::covr
           needs: coverage
 
       - name: Generate coverage report

diff --git a/.github/workflows/dev_check.yml b/.github/workflows/dev_check.yml
@@ -42,7 +42,24 @@ jobs:
           _R_CHECK_RD_XREFS: false
         with:
           dependencies: '"hard"' # do not use suggested dependencies
-          extra-packages: any::rcmdcheck, any::testthat, any::rlang, any::R.utils, any::knitr, any::rmarkdown, any::qs, any::sp, any::stars, any::raster, any::sf, any::scattermore, any::exactextractr, any::RTriangle, any::geometry, github::drieslab/GiottoData
+          install-pandoc: false
+          extra-packages: |
+            any::rcmdcheck
+            any::testthat
+            any::rlang
+            any::R.utils
+            any::knitr
+            any::rmarkdown
+            any::qs
+            any::sp
+            any::stars
+            any::raster
+            any::sf
+            any::scattermore
+            any::exactextractr
+            any::RTriangle
+            any::geometry
+            github::drieslab/GiottoData
 
       - name: Run R CMD check
         uses: r-lib/actions/check-r-package@v2

diff --git a/.github/workflows/main_check.yml b/.github/workflows/main_check.yml
@@ -58,7 +58,24 @@ jobs:
           _R_CHECK_RD_XREFS: false
         with:
           dependencies: '"hard"' # do not use suggested dependencies
-          extra-packages: any::rcmdcheck, any::testthat, any::rlang, any::R.utils, any::remotes, any::knitr, any::rmarkdown, any::sp, any::stars, any::raster, any::sf, any::scattermore, any::exactextractr, any::RTriangle, any::geometry, github::drieslab/GiottoData
+          install-pandoc: false
+          extra-packages: |
+            any::rcmdcheck
+            any::testthat
+            any::rlang
+            any::R.utils
+            any::remotes
+            any::knitr
+            any::rmarkdown
+            any::sp
+            any::stars
+            any::raster
+            any::sf
+            any::scattermore
+            any::exactextractr
+            any::RTriangle
+            any::geometry
+            github::drieslab/GiottoData
 
       - name: Test python env build
         run: |

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: GiottoClass
 Title: Giotto Suite object definitions and framework
-Version: 0.2.1
+Version: 0.2.2
 Authors@R: c(
 	person("Ruben", "Dries", email = "rubendries@gmail.com",
 		 role = c("aut", "cre")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,18 @@
 
 
+# GiottoClass 0.2.2 (2024/03/01)
+
+## bug fixes
+- fix `createGiottoPolygonsFromMask()` IDs being applied out of sync to mask values
+- fix `createGiottoPolygon()` `character` method dispatch for `raster` inputs
+- remove unused `fix_multipart` param in `createGiottoPolygonsFromMask()`
+- fix `giottoPolygon` ID caching after `rbind()`
+
+## enhancements
+- `createGiottoPolygonsFromMask()` now has `ID_fmt` param for finer control of automatic `poly_ID` generation
+- `.flip_spatvect()` internal for flipping `SpatVector` across arbitrary x and y vals
+
+
 # GiottoClass 0.2.1 (2024/02/28)
 
 ## breaking changes