v0.2.2 : hotfix for createGiottoPolygon()
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jiajic
commented
Mar 1, 2024
jiajic
commented
- added tests for creation from mask file
- added runnable examples for data.frame-like, mask image, vector file
- fix dispatch for character type inputs
- add internal flip function for terra SpatVectors that has functional parity with the one GiottoClass defines for giottoPolygon
- add new toy mask and vector files for testing & examples with createGiottoPolygon
- fix poly_ID setting for mask inputs
## bug fixes - fix `createGiottoPolygonsFromMask()` IDs being applied out of sync to mask values - remove unused `fix_multipart` param in `createGiottoPolygonsFromMask()` ## enhancements - `createGiottoPolygonsFromMask()` now has `ID_fmt` param for finer control of automatic poly_ID generation
terra has a flip function, but this internal adds the ability to flip over arbitrary x and y values in the same manner that has been implemented for `giottoPolygon` and `giottoPoints`
Also updates to documentation and examples
- also specifically show the needed columns for `data.frame-like` inputs
fix: `createGiottoPolygon()` further fixes and documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.