v0.3.1 #197
Merged
v0.3.1 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace wrap_msg -> print to avoid error printing list
- allow NULL inputs, which are interpreted as 0 shifts - allow z manipulations even when z values are not originally in these objects to facilitate z stacking. - add col ordering before outputs for zstacking
- update to be compatible now that @largeImages slot is gone - object extent detection and xshift defaults no longer depend on images, but `ext()` of the `gobject` - update xy shifts to use `spatShift()`
- fix image slot updates when no giottoLargeImages in object - fix a print statement in createGiottoObjectSubcellular
- also fix error when `joinGiottoObjects` only has one spatLocsObj and a list input is expected
- fix get_giottoLargeImage() and get_giottoImage_MG
- GiottoData 0.2.11.0 changes the image name of the he image from he back to 'image'. Update the examples that have already been switched back to that name.
Dev2 with lower requirements and remotes added back
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintr found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GiottoClass 0.3.1
bug fixes
setGiotto()with...spatShift()can now perform z shifts when startspatLocsObjhas no z informationjoinGiottoObjects()after v0.3.0 where it looks for the now non-existent@largeImagesslot.update_image_slot()after v0.3.0 where a NULL@largeImagesslot will result in an errorspatShift()andrescale()methods forgiottowhen setting a defaultspat_unitandfeat_typeenhancements
joinGiottoObjects()extent detection and xshift defaults now depend onext()of the gobject instead of any images (when available)joinGiottoObjects()now has adry_runparam for previewing where datasets will be spatially located after the joinnew
as()conversion fromgiottoLargeImagetoarrayas.matrix()method forspatLocsObj()