v0.0.0.9008 #73
Merged
v0.0.0.9008 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Version bump - export of some functions that are required by other modules - add ability to calculate centroids for giottoPolygons but return the attached objects instead of the centroids.
- run document - refactor calculateOverlapRaster to have the workflow portion be its own separate function so that input can be a poly and points SpatVector instead of a giotto object
- missing param for counts info added
Code cleanup, `as.stars()`, `as.sf()`, `centroids()` updates
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintr found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
giottoPolygonsbut return the attached objects instead of the centroids.as.stars()converter forgiottoPolygonandgiottoPointsas.sf()converter forgiottoPolygonso that it also converts the centroids and overlaps informationcentroids()so it can calculate centroids forgiottoPolygonsbut return the attached objects instead of the centroids.calculateOverlapRaster()to have the workflow portion be its own separate function so that input can be a poly and pointsSpatVectorinstead of a giotto object