Ensure that the timezone doesn't leak into zips. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using SOURCE_DATE_EPOCH, previous code was using time.localtime which is affected by the system timezone. The test code here with tzset likely does not demonstrate the problem on Windows, but hopefully is just a no-op there.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
- Coverage 90.7% 90.6% -0.1%
=======================================
Files 2 2
Lines 162 161 -1
=======================================
- Hits 147 146 -1
Misses 15 15
|
|
Ahhh, thanks for the catch! I definitely did not pay enough attention when I looked up how to convert from epoch seconds to a I approved this PR to run the CI, and unfortunately, it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello from a fellow connoisseur of zip files. I saw a new release of this project and wondered how you did it, and found one source of non-deterministic builds in that the system timezone affects how SOURCE_DATE_EPOCH is used.
I'm not able to run the tests on CI in my fork, so I don't know if Windows is passing with this test. I'm a little concerned that "Availability: Unix" in the docs for time.tzset means the function doesn't even exist, but I'm hoping it does exist and is a no-op. CI will tell.