Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: version bumps in dependencies #20

Merged
merged 11 commits into from
Jun 23, 2023
Merged

Draft: version bumps in dependencies #20

merged 11 commits into from
Jun 23, 2023

Conversation

badrbouslikhin
Copy link
Contributor

@badrbouslikhin badrbouslikhin commented Jun 20, 2023

Hello,

I wanted to bring to your attention some compilation issues that I encountered while trying to start a new Bluetooth Mesh project based on the drogue-device repository. Specifically, I ran into issues related to dependencies updates, including embassy-sync, embassy-nrf, nrf-softdevice, and embedded-storage-async. Additionally, some of these issues were also related to recent Rust nightlies, specifically TAIT for async traits.

I have created a draft pull request to address these issues, and I would be happy to make any necessary changes that you may suggest.

Note: one of the commits (105a076) contains numerous modifications related to formatting.

Thank you for your time working on this project!

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks good to me.

@badrbouslikhin
Copy link
Contributor Author

Just wanted to let you know that I've made some new commits that should fix the compilation issues in the examples. Could you take a quick look at d275be6 and let me know what you think?

Also, I've been having some trouble with the cargo test job in CI. I've been trying to figure it out, but it seems related to embassy-time and its std features. Any ideas on how to fix this?

Thanks for your help!

@lulf
Copy link
Member

lulf commented Jun 22, 2023

That commit looks good, saving that clone is great.

I'll look into the CI failures some time today or tomorrow, I think some flag on critical-section is needed maybe.

This commit enables the `rt` feature gate in the Embassy HALs, which was introduced in commit 8c93805.
This feature gate provides access to the reset and runtime code necessary for ARM Cortex-M microcontrollers,
allowing for low-level functionality such as exception handling and interrupt handling.
@badrbouslikhin
Copy link
Contributor Author

badrbouslikhin commented Jun 22, 2023

Commit a4ca5a0 enables the rt feature gate in the Embassy nRF HAL, which was introduced in commit 8c93805.

Enabling this feature gate was necessary to make the examples functional, as the provisioning was not working without it.

@lulf
Copy link
Member

lulf commented Jun 23, 2023

@badrbouslikhin Can you apply this change:

diff --git a/btmesh-driver/Cargo.toml b/btmesh-driver/Cargo.toml
index 40b8899..abc3e04 100644
--- a/btmesh-driver/Cargo.toml
+++ b/btmesh-driver/Cargo.toml
@@ -17,6 +17,7 @@ embassy-sync = { version = "0.2.0", default-features = false, features = [
   "nightly",
 ] }
 embassy-futures = { version = "0.1.0", default-features = false }
+critical-section = { version = "1.1.1", default-features = false, optional = true }
 heapless = "0.7"
 hash32 = "0.2.1"
 hash32-derive = "0.1.1"
@@ -40,7 +41,7 @@ rand_core = { version = "0.6.2", default-features = false, features = [
 
 [features]
 default = ["flash", "memory", "relay", "std"]
-std = ["embassy-time/std"]
+std = ["embassy-time/std", "critical-section/std"]
 flash = [
   "embedded-storage",
   "embedded-storage-async",

This makes it work for me

@badrbouslikhin
Copy link
Contributor Author

Thanks! It works locally for me too. Let's see if the CI is happy.

@lulf lulf merged commit 3eb12b0 into drogue-iot:main Jun 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants