Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support publish retransmit #23

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Conversation

badrbouslikhin
Copy link
Contributor

This pull request (PR) finalizes the partial implementation of publish retransmit. Certain necessary components were missing to properly convey retransmit commands to the main application from the foundation models.

Similar to issue #22, there was also an error in the bit numbering, resulting in an incorrect setting for the publishing period.

This contribution was made by our intern @Trompettesib and has undergone internal review and testing.

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enhancements look good to me, thanks! 🚀

@lulf lulf merged commit 9ced9b4 into drogue-iot:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants