Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new flutter_custom_tabs_android plugin package #106

Merged
merged 2 commits into from
Sep 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .github/workflows/android_implementation_package.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@

name: CI for android implementation package

on:
push:
branches:
- main
- develop
paths:
- 'flutter_custom_tabs_android/**'
pull_request:
paths:
- 'flutter_custom_tabs_android/**'

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: 17
- uses: subosito/flutter-action@v2
with:
channel: 'stable'
- name: Get flutter dependencies
run: flutter pub get
working-directory: ./flutter_custom_tabs_android
- name: Check for any formatting issues in the code
run: dart format --set-exit-if-changed .
working-directory: ./flutter_custom_tabs_android
- name: Statically analyze the Dart code for any errors
run: flutter analyze .
working-directory: ./flutter_custom_tabs_android
- name: Run unit tests
run: flutter test
working-directory: ./flutter_custom_tabs_android
- name: Build example android app
run: flutter build apk --release
working-directory: ./flutter_custom_tabs_android/example
2 changes: 1 addition & 1 deletion .github/workflows/app_facing_package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
working-directory: ./flutter_custom_tabs
- name: Build example android app
run: flutter build apk --release
working-directory: ./flutter_custom_tabs/example
working-directory: ./flutter_custom_tabs/example
- name: Build example iOS app
run: flutter build ios --no-codesign
working-directory: ./flutter_custom_tabs/example
4 changes: 2 additions & 2 deletions .github/workflows/web_implementation_package.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

name: CI for web implementation package
name: CI for the web implementation package

on:
push:
Expand All @@ -14,7 +14,7 @@ on:

jobs:
build:
runs-on: macos-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
Expand Down
1 change: 0 additions & 1 deletion flutter_custom_tabs/android/settings.gradle

This file was deleted.

5 changes: 2 additions & 3 deletions flutter_custom_tabs/lib/flutter_custom_tabs.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
export 'package:flutter_custom_tabs_platform_interface/flutter_custom_tabs_platform_interface.dart'
hide CustomTabsPlatform;
export 'package:flutter_custom_tabs_android/flutter_custom_tabs_android.dart'
hide CustomTabsPlugin;

export 'src/custom_tabs_animation.dart';
export 'src/custom_tabs_close_button.dart';
export 'src/custom_tabs_color_scheme.dart';
export 'src/launcher.dart';
7 changes: 5 additions & 2 deletions flutter_custom_tabs/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ dependencies:
# TODO: To be removed before v2.0.0 release
flutter_custom_tabs_platform_interface:
path: ../flutter_custom_tabs_platform_interface
# TODO: To be removed before v2.0.0 release
# flutter_custom_tabs_android: ^2.0.0
flutter_custom_tabs_android:
path: ../flutter_custom_tabs_android
# flutter_custom_tabs_web: ^1.1.0
# TODO: To be removed before v2.0.0 release
flutter_custom_tabs_web:
Expand All @@ -35,8 +39,7 @@ flutter:
plugin:
platforms:
android:
package: com.github.droibit.flutter.plugins.customtabs
pluginClass: CustomTabsPlugin
default_package: flutter_custom_tabs_android
ios:
pluginClass: GDBCustomTabsPlugin
web:
Expand Down
30 changes: 30 additions & 0 deletions flutter_custom_tabs_android/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Miscellaneous
*.class
*.log
*.pyc
*.swp
.DS_Store
.atom/
.buildlog/
.history
.svn/
migrate_working_dir/

# IntelliJ related
*.iml
*.ipr
*.iws
.idea/

# The .vscode folder contains launch configuration and tasks you configure in
# VS Code which you may wish to be included in version control, so this line
# is commented out by default.
#.vscode/

# Flutter/Dart/Pub related
# Libraries should not include pubspec.lock, per https://dart.dev/guides/libraries/private-files#pubspeclock.
/pubspec.lock
**/doc/api/
.dart_tool/
.packages
build/
30 changes: 30 additions & 0 deletions flutter_custom_tabs_android/.metadata
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# This file tracks properties of this Flutter project.
# Used by Flutter tool to assess capabilities and perform upgrades etc.
#
# This file should be version controlled and should not be manually edited.

version:
revision: "e1e47221e86272429674bec4f1bd36acc4fc7b77"
channel: "stable"

project_type: plugin

# Tracks metadata for the flutter migrate command
migration:
platforms:
- platform: root
create_revision: e1e47221e86272429674bec4f1bd36acc4fc7b77
base_revision: e1e47221e86272429674bec4f1bd36acc4fc7b77
- platform: android
create_revision: e1e47221e86272429674bec4f1bd36acc4fc7b77
base_revision: e1e47221e86272429674bec4f1bd36acc4fc7b77

# User provided section

# List of Local paths (relative to this file) that should be
# ignored by the migrate tool.
#
# Files that are not part of the templates will be ignored by default.
unmanaged_files:
- 'lib/main.dart'
- 'ios/Runner.xcodeproj/project.pbxproj'
3 changes: 3 additions & 0 deletions flutter_custom_tabs_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2.0.0

* TODO: Describe initial release.
Loading