Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct (short) week string result when set start of week #203

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

xwjdsh
Copy link
Contributor

@xwjdsh xwjdsh commented Nov 24, 2023

Close #200

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (731fdcb) 100.00% compared to head (85ff137) 99.90%.

❗ Current head 85ff137 differs from pull request most recent head 760c884. Consider uploading reports for the commit 760c884 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #203      +/-   ##
===========================================
- Coverage   100.00%   99.90%   -0.10%     
===========================================
  Files           20       20              
  Lines         3080     3068      -12     
===========================================
- Hits          3080     3065      -15     
- Misses           0        2       +2     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gouguoyin gouguoyin merged commit 004e90d into dromara:master Nov 30, 2023
1 check passed
@xwjdsh xwjdsh deleted the fix/to-week-string branch November 30, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToWeekString() ignores SetWeekStartsAt()
2 participants