Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VietNam lunar calendar #214

Closed
wants to merge 1 commit into from
Closed

Conversation

culy247
Copy link

@culy247 culy247 commented Jan 4, 2024

No description provided.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (973d8b6) 100.00% compared to head (4372f35) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #214    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           22        23     +1     
  Lines         2965      3502   +537     
==========================================
+ Hits          2965      3502   +537     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@culy247 culy247 force-pushed the feature/vi-lunar branch 3 times, most recently from 0068299 to d1ba9f0 Compare January 4, 2024 10:30
@culy247
Copy link
Author

culy247 commented Jan 4, 2024

@gouguoyin Review pr for me

@gouguoyin
Copy link
Collaborator

I am planning to reconstruct the calendar. Each calendar is an independent package.so not accept PR until the specific plan is finalized.

@culy247 culy247 force-pushed the feature/vi-lunar branch 4 times, most recently from 60e8de1 to 2ad792b Compare January 8, 2024 00:49
@culy247
Copy link
Author

culy247 commented Jan 8, 2024

I am planning to reconstruct the calendar. Each calendar is an independent package.so not accept PR until the specific plan is finalized.

@gouguoyin Thank you, you can shame me your plan?

@gouguoyin
Copy link
Collaborator

gouguoyin commented Jan 8, 2024

It's not finalized yet, do you have any good ideas?

carbon.CreateFromCalendar(c Calendar)
carbon.ToCalendar(c Calendar)

image

@gouguoyin
Copy link
Collaborator

gouguoyin commented Jan 22, 2024

You can refer to the latest Chinese Lunar to contribute VietNam lunar calendar,must include CreateFromSolar and CreateFromVLunar methods

@culy247
Copy link
Author

culy247 commented Jan 23, 2024

You can refer to the latest Chinese Lunar to contribute VietNam lunar calendar,must include ToGregorian and ToVLunar methods

thank you.

@culy247 culy247 closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants