Fix integer overflow converting Lunar to Gregorian on 386 arch #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: golang-module/carbon/issues/219 Signed-off-by: liutianqi <zixizixi@vip.qq.com>
|
@gouguoyin 有空的话请 review 此 PR，谢谢。如果有更好的解决方案请随时关闭。 |
@gouguoyin Please review this PR if you have time, thank you. If there is a better solution please feel free to close. |
|
和我的修复方案一样，不过我的还没提交 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2553 2553
=========================================
Hits 2553 2553 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOARCH=386Fix: #219