Skip to content
This repository has been archived by the owner on Apr 24, 2018. It is now read-only.

Parameters specified in the routes themselves are never decoded #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ecton
Copy link

@ecton ecton commented Jun 3, 2013

This commit makes parameters within a URL be decoded, just like the regular query parameters. For example, the route "/test/:name/foo" and the path: "/test/Test+User/foo" should result in the string "Test User" for the ":name" key, not "Test+User".

This patch applies that, and in an attempt to keep it from choking on invalid escapes, it defaults back to the original match if QueryUnescape fails. This is my preferred behavior, but doesn't necessarily match what your vision for how this project was meant to process that type of failure.

@tommydenton
Copy link

First comment on first pull :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants