-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempting to fix CI for ARM Mac and older dotnet format tool compatbility #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 51.33% 47.89% -3.44%
==========================================
Files 14 17 +3
Lines 1422 1570 +148
Branches 0 137 +137
==========================================
+ Hits 730 752 +22
- Misses 692 776 +84
- Partials 0 42 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sahujapersonal
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current CI builds fail. There are a few issues that this PR attempts to resolve:
You can resolve the problem by installing the 'X64' .NET.
. This is due tomacos-latest
being an ARM based runner, and .NET Standard 2.0/.NET 5 only supports x64. I moved tomacos-13
which appears to be the latest version still using Intel CPUs. Note thatmacos-11
is being deprecated on 6/28/2024 so we should have some time yet withmacos-13
to upgrade the SDK to support ARM build.--fix-
commands are not supported in dotnet format 6 and above. I pinned the version to 5 that still supports them. Ideally we'd want to see how to configure the latest format tool to do what we want, but for a quick fix/test I'm trying the "original" version. This also required moving fromdotnet format
(which always ran the latest version) todotnet-format
(which did run the correct version that was installed).Also updated the contribution doc with the above dotnet format version and removed the Stone generation section as it is no longer supported (instead being handled by the Spec Update action).
Checklist
General Contributing
Is This a Code Change?
Validation