-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 Standards Fixes #97
base: master
Are you sure you want to change the base?
Conversation
--------- BEGIN META VARIABLES -------- Project : dropbox-sdk-python Task : PEP8 Standards Fixes Done : 3-16-17 --------- END META VARIABLES --------
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Please consider updating the flake8
section of tox.ini
and the MESSAGES CONTROL
section of .pylintrc
to reflect the changes. This will likely mean turning back on certain linter options, but some experimentation may be necessary.
print("Finding available revisions on Dropbox...") | ||
entries = dbx.files_list_revisions(BACKUPPATH, limit=30).entries # pylint: disable=no-member | ||
entries = dbx.files_list_revisions( | ||
BACKUPPATH, limit=30).entries # pylint: disable=no-member |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking up this line confuses the linter. Consider instead:
revisions = dbx.files_list_revisions(BACKUPPATH, limit=30)
entries = revisions.entries # pylint: disable=no-member
--------- BEGIN META VARIABLES -------- Project : dropbox-sdk-python Task : Cleaning up backup-and-restore-example.py Done : 3-16-17 --------- END META VARIABLES --------
--------- BEGIN META VARIABLES -------- Project : dropbox-sdk-python Task : Addressing linter error on travis CI build for prior commit to backup-and-restore-example.py Done : 3-16-17 --------- END META VARIABLES --------
Project : dropbox-sdk-python Task : Updating tox.ini to ignore E1101 (no-member) Done : 3-16-17 --------- END META VARIABLES --------
Hey Matt, my pleasure. Broke up the revision retrieval code, and fixed a subsequent E261 error. Also added E1101 to tox.ini, it looks like MESSAGES CONTROL for .pylintrc already has locally-disabled disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dmchale92, it looks good. If you can squash commits, I'll merge. Thanks!
As an aside, |
f2cf463
to
afadb2d
Compare
Hello, If you are still interested in updating this piece of code, please acknowledge this message and make the necessary updates. |
|
--------- BEGIN META VARIABLES --------
Project : dropbox-sdk-python
Task : PEP8 Standards Fixes
Done : 3-16-17
--------- END META VARIABLES --------