Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 Standards Fixes #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

PEP8 Standards Fixes #97

wants to merge 4 commits into from

Conversation

Dmchale92
Copy link

--------- BEGIN META VARIABLES --------
Project : dropbox-sdk-python
Task : PEP8 Standards Fixes
Done : 3-16-17
--------- END META VARIABLES --------

--------- BEGIN META VARIABLES --------
Project : dropbox-sdk-python
Task : PEP8 Standards Fixes
Done : 3-16-17
--------- END META VARIABLES --------
Copy link
Contributor

@posita posita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Please consider updating the flake8 section of tox.ini and the MESSAGES CONTROL section of .pylintrc to reflect the changes. This will likely mean turning back on certain linter options, but some experimentation may be necessary.

print("Finding available revisions on Dropbox...")
entries = dbx.files_list_revisions(BACKUPPATH, limit=30).entries # pylint: disable=no-member
entries = dbx.files_list_revisions(
BACKUPPATH, limit=30).entries # pylint: disable=no-member
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking up this line confuses the linter. Consider instead:

revisions = dbx.files_list_revisions(BACKUPPATH, limit=30)
entries = revisions.entries  # pylint: disable=no-member

--------- BEGIN META VARIABLES --------
Project : dropbox-sdk-python
Task : Cleaning up backup-and-restore-example.py
Done : 3-16-17
--------- END META VARIABLES --------
--------- BEGIN META VARIABLES --------
Project : dropbox-sdk-python
Task : Addressing linter error on travis CI build for prior commit to
backup-and-restore-example.py
Done : 3-16-17
--------- END META VARIABLES --------
Project : dropbox-sdk-python
Task : Updating tox.ini to ignore E1101 (no-member)
Done : 3-16-17
--------- END META VARIABLES --------
@Dmchale92
Copy link
Author

Dmchale92 commented Mar 16, 2017

Hey Matt, my pleasure. Broke up the revision retrieval code, and fixed a subsequent E261 error. Also added E1101 to tox.ini, it looks like MESSAGES CONTROL for .pylintrc already has locally-disabled disabled.

Copy link
Contributor

@posita posita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dmchale92, it looks good. If you can squash commits, I'll merge. Thanks!

@posita
Copy link
Contributor

posita commented Mar 22, 2017

As an aside, ez_setup.py comes from elsewhere (formerly from PEAK, now from PyPA). We might consider removing it altogether in the future and leave bootstrapping setuptools up to the installer. I think most modern versions of Python already include it anyway.

@posita posita force-pushed the master branch 2 times, most recently from f2cf463 to afadb2d Compare May 11, 2017 18:21
@rogebrd
Copy link
Contributor

rogebrd commented Mar 30, 2020

Hello, If you are still interested in updating this piece of code, please acknowledge this message and make the necessary updates.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants