Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FactorialCalculator implementation improved to handle large factorials #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

FactorialCalculator implementation improved to handle large factorials #2

wants to merge 3 commits into from

Commits on Oct 31, 2022

  1. Added missing tests for FactorialCalculator

    @xhafan
    xhafan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    4eac30d View commit details
    Browse the repository at this point in the history

  2. Refactored FactorialCalculator to return the factorial in BigInteger … 

    …type in order to handle numbers where the factorial is larger than long.MaxValue; added missing test for "minimum" values
    @xhafan
    xhafan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    be67413 View commit details
    Browse the repository at this point in the history

  3. Fixed the FactorialCalculator behaviour for negative values

    @xhafan
    xhafan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    30b3c6d View commit details
    Browse the repository at this point in the history