-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inference Semantics #113
Comments
Good: the names of things are important. There are several different A. Compare shapes of background galaxies lensed by a realistic density
B. Compare observed (fixed) and model-predicted galaxy shapes, in order to
On Sun, Nov 6, 2016 at 5:09 PM, David Thomas notifications@github.com
|
The names in my original post are fictitious and exist solely for the purpose of simplifying communication. My confusion was not with names, but rather that the 'calculate_log_likelihood' method, which currently computes neither A nor B. A simple way to see this is that the 'calculate_log_likelihood' method only ever makes a comparison with variables computed with lens_by_halos or lens_by_map but never compares variables across both (see lines 920-928 in background.py). It seems like the conclusion is that we should (i) write a method that computes B, and (ii) use this method in our inference notebooks. |
The code for comparing the 'true' ray traced reduced shear (g_i_true) of a background galaxy to its Pangloss predicted ellipticity (e_i_predicted) still confuses me.
Lines 919-926 in background.py on 'wl' branch are good reference. What am I missing?
The text was updated successfully, but these errors were encountered: