test

nodes/NetSuite/NetSuite.node.ts

@@ -24,8 +24,7 @@ import {
 
 import { makeRequest } from '@fye/netsuite-rest-api';
 
-import * as pLimit from 'p-limit';
-import { response } from 'express';
+import pLimit from 'p-limit';
 
 const debug = debuglog('n8n-nodes-netsuite');
 
@@ -35,7 +34,7 @@ const handleNetsuiteResponse = (fns: IExecuteFunctions, response: INetSuiteRespo
 	let body: JsonObject = {};
 	const {
 		title: webTitle = undefined,
-		code: restletCode = undefined,
+		// code: restletCode = undefined,
 		'o:errorCode': webCode,
 		'o:errorDetails': webDetails,
 		message: restletMessage = undefined,
@@ -46,7 +45,7 @@ const handleNetsuiteResponse = (fns: IExecuteFunctions, response: INetSuiteRespo
 			message = webDetails[0].detail || message;
 		}
 		if (fns.continueOnFail() !== true) {
-			const code = webCode || restletCode;
+			// const code = webCode || restletCode;
 			const error = new NodeApiError(fns.getNode(), response.body);
 			error.message = message;
 			throw error;
@@ -138,7 +137,7 @@ export class NetSuite implements INodeType {
 		nodeContext.count = limit;
 		nodeContext.offset = offset;
 		// debug('requestData', requestData);
-		while ((returnAll || returnData.length < limit) && hasMore === true) {			
+		while ((returnAll || returnData.length < limit) && hasMore === true) {
 			const response = await makeRequest(getConfig(credentials), requestData);
 			const body: JsonObject = handleNetsuiteResponse(fns, response);
 			const { hasMore: doContinue, items, links, offset, count, totalResults } = (body.json as INetSuitePagedBody);
@@ -199,7 +198,7 @@ export class NetSuite implements INodeType {
 		nodeContext.count = limit;
 		nodeContext.offset = offset;
 		debug('requestData', requestData);
-		while ((returnAll || returnData.length < limit) && hasMore === true) {			
+		while ((returnAll || returnData.length < limit) && hasMore === true) {
 			const response = await makeRequest(config, requestData);
 			const body: JsonObject = handleNetsuiteResponse(fns, response);
 			const { hasMore: doContinue, items, links, count, totalResults, offset } = (body.json as INetSuitePagedBody);
@@ -328,7 +327,7 @@ export class NetSuite implements INodeType {
 		}
 
 		if (nodeOptions.fullResponse) {
-			return { 
+			return {
 				json: {
 					statusCode: response.statusCode,
 					headers: response.headers,

package.json

@@ -1,6 +1,6 @@
 {
     "name": "n8n-nodes-netsuite",
-    "version": "0.7.4",
+    "version": "0.7.5",
     "description": "n8n node for NetSuite using the REST API",
     "license": "MIT",
     "homepage": "https://github.com/drudge/n8n-nodes-netsuite",
@@ -46,11 +46,12 @@
     "devDependencies": {
         "@types/express": "^4.17.6",
         "@types/jest": "^26.0.13",
+        "@types/luxon": "^3.3.0",
         "@types/node": "^14.17.27",
         "@types/request-promise-native": "~1.0.15",
         "@typescript-eslint/eslint-plugin": "^5.29.0",
         "@typescript-eslint/eslint-plugin-tslint": "^5.29.0",
-        "@typescript-eslint/parser": "^5.29.0",
+        "@typescript-eslint/parser": "~5.45",
         "eslint": "^8.18.0",
         "eslint-plugin-import": "^2.26.0",
         "eslint-plugin-jsdoc": "^39.3.3",
@@ -61,7 +62,7 @@
         "n8n-workflow": "*",
         "nodelinter": "^0.1.9",
         "ts-jest": "^26.3.0",
-        "typescript": "~4.3.5"
+        "typescript": "~4.8.4"
     },
     "dependencies": {
         "@fye/netsuite-rest-api": "^2.0.0",

tsconfig.json

@@ -1,33 +1,29 @@
 {
 	"compilerOptions": {
-		"lib": [
-			"es2017",
-			"es2019.array"
-		],
-		"types": [
-			"node",
-			"jest"
-		],
+		"strict": true,
 		"module": "commonjs",
-		"noImplicitAny": true,
+		"moduleResolution": "node",
+		"target": "es2019",
+		"lib": ["es2019", "es2020"],
 		"removeComments": true,
+		"forceConsistentCasingInFileNames": true,
+		"noImplicitAny": true,
+		"noImplicitReturns": true,
+		"noUnusedLocals": true,
 		"strictNullChecks": true,
-		"strict": true,
 		"preserveConstEnums": true,
+		"esModuleInterop": true,
 		"resolveJsonModule": true,
+		"incremental": true,
 		"declaration": true,
+		"sourceMap": true,
+		"skipLibCheck": true,
 		"outDir": "./dist/",
-		"target": "es2017",
-		"sourceMap": true
 	},
 	"include": [
 		"credentials/**/*",
-		"src/**/*",
 		"nodes/**/*",
 		"nodes/**/*.json",
-		"test/**/*"
+		"package.json",
 	],
-	"exclude": [
-		"**/*.spec.ts"
-	]
-}
+}