Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin::scaffold call is deprecated but README says it should be added to post-install commands #113

Open
aaleksu opened this issue Sep 17, 2020 · 5 comments

Comments

@aaleksu
Copy link

aaleksu commented Sep 17, 2020

How is that possible that in 2.6.1 version in README you say that post-install-cmd should be adjusted with "DrupalComposer\DrupalScaffold\Plugn::scaffold()",
but Plugin::scaffold method has this as its first line: https://github.com/drupal-composer/drupal-scaffold/blob/2.6.1/src/Plugin.php#L96?

@greg-1-anderson
Copy link
Collaborator

greg-1-anderson commented Sep 17, 2020

Oh, if I had to guess I'd say that the README is out of date, but I don't really remember the fine details of this project, the entirety of which is deprecated.

Everyone should move to drupal/core-composer-scaffold. It is recommended, supported, and more performant, not to mention works with Drupal 9 and Composer 2.

@webflo
Copy link
Member

webflo commented Sep 17, 2020

@greg-1-anderson is right. You should look at drupal/core-composer-scaffold. I skimmed through the README and could not find the part you mentioned about post-install-cmd.

@greg-1-anderson
Copy link
Collaborator

I updated the README to advise that this project is deprecated.

@marcvangend
Copy link

Thanks @greg-1-anderson. Could you elaborate a bit on the "everyone should move to drupal/core-composer-scaffold" part? What do I need to do to make the switch? Is is required to move to core-composer-scaffold when I upgrade my site to D9?

@greg-1-anderson
Copy link
Collaborator

Yes, drupal-composer/drupal-scaffold will not support Drupal 9 or Composer 2, so everyone will have to switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants