Add BehatCommands for Drush 9 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhedstrom
reviewed
Sep 19, 2018
There was a problem hiding this comment.
This looks good. Just these nits.
Want to open a PR against the DrupalExtension that targets this branch of the behat drush endpoint to see if tests start passing again? There's this related issue jhedstrom/drupalextension#458
BehatCommands.php
Outdated
| @@ -0,0 +1,202 @@ | |||
| <?php | |||
| namespace Drush\Commands\example_site_wide_command; | |||
There was a problem hiding this comment.
This should probably be updated to BehatDrushEndpoint or similar?
There was a problem hiding this comment.
It will be behat_drush_endpoint
BehatCommands.php
Outdated
| * | ||
| * @see Drupal\Driver\Cores\AbstractCore\expandEntityFields | ||
| */ | ||
| function expandEntityFields($entity_type, \stdClass $entity) { |
There was a problem hiding this comment.
This and the other methods that don't already should probably specify visibility (protected, public, etc) for clarity.
greg-1-anderson
force-pushed
the
drush-9-support
branch
from
3574ae5
to
8293eb5
Compare
greg-1-anderson
pushed a commit
that referenced
this pull request
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires drush-ops/drush#3687, which I will merge shortly.