Fix issue #5534. mysql password quoting #5536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it was suggested enclosing the password in backticks would resolve this. Further testing indicated that it didn't work when the password contains a backtick. Also, the quoting mentioned in my previous attempt at a PR regarding the database name doesn't really have anything to do with this in my opinion. I could put a check in to see if that was set but again in my opinion there is never a reason to not perform what the fix is doing since it is always a possiblity that a user will use a backtick in their password.
wdouglascampbell
requested review from
weitzman and
greg-1-anderson
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it was suggested enclosing the password in backticks would resolve this. Further testing indicated that it didn't work when the password contains a backtick. Also, the quoting mentioned in my previous attempt at a PR regarding the database name doesn't really have anything to do with this in my opinion. I could put a check in to see if that was set but again in my opinion there is never a reason to not perform what the fix is doing since it is always a possibility that a user will use a backtick in their password.