Add key? method to rule blocks #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 14, 2019
flash-gordon
requested changes
Jun 14, 2019
houndci-bot
reviewed
Jun 14, 2019
houndci-bot
reviewed
Jun 14, 2019
added 4 commits
June 14, 2019 12:03
This is helpful when dealing with optional keys. We can't just assume that we do not want to execute a rule when a value was missing. Good example: a password must be provided when login is provided, and both are optional. Refs #540
solnic
force-pushed
the
540-fix-handling-of-optional-keys
branch
from
6f8ab38
to
fad5f40
Compare
timriley
reviewed
Jun 14, 2019
houndci-bot
reviewed
Jun 14, 2019
added 2 commits
June 14, 2019 12:11
flash-gordon
approved these changes
Jun 14, 2019
solnic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful when dealing with optional keys. We can't just assume
that we do not want to execute a rule when a value was missing.
Good example: a password must be provided when login is provided, and
both are optional.
Refs #540