Fix macros expecting a range as option

[waiting-for-dev]

References #608

[solnic]

Thanks. I only left one minor style-related comment. Other than that it's good to go.

[waiting-for-dev]

Do you mean the whole `each` block or just the array push? In the first case, maybe line length is too high...

…

On Thu, Jan 16, 2020, 09:28 Piotr Solnica ***@***.***> wrote: ***@***.**** approved this pull request. Thanks. I only left one minor style-related comment. Other than that it's good to go. ------------------------------ In lib/dry/validation/rule.rb <#616 (comment)>: > else macros << Array(spec) end end end + + def add_macro_from_hash(macros, spec) + spec.each do |k, v| + macros << [ + k, + v.is_a?(Array) ? v : [v] + ] could you inline this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#616?email_source=notifications&email_token=AAAM3KRUL2Q6527GUGSFZMDQ6ALBNA5CNFSM4KHHBDGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCR6QZAA#pullrequestreview-343739520>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAM3KTIYIV5H5W5MIASPWDQ6ALBNANCNFSM4KHHBDGA> .

[solnic]

@waiting-for-dev just the array push. re line-length, I think these days with gigantic screen resolutions 100 is a sensible value, but we can change it to more standard 80

[waiting-for-dev]

Ok @solnic , I forced a push with the change in style. About line length, I'm always nostalgic of the old times, so I like the 80 limit, even if I recognize it's sometimes insane 😄