Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task Generate_Markdown_For_DSC_Resources to use old config key #162

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Oct 22, 2024

Pull Request (PR) description

  • Task Generate_Markdown_For_DSC_Resources
    • Outputs a warning message if the old configuration key is used in the
      build configuration but keeps using the old configuration key.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (66b21b9) to head (a403f5f).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #162   +/-   ##
===================================
  Coverage    94%    94%           
===================================
  Files        70     70           
  Lines      1321   1324    +3     
===================================
+ Hits       1244   1247    +3     
  Misses       77     77           
Files with missing lines Coverage Δ
...asks/Generate_Markdown_For_DSC_Resources.build.ps1 88% <100%> (+2%) ⬆️

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 02e340b into dsccommunity:main Oct 23, 2024
14 checks passed
@johlju johlju deleted the fix/issue-161 branch October 23, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate_Markdown_For_DSC_Resources: Cannot find the metadata configuration
1 participant